[libvirt] [PATCHv2 5/6] event: convert remaining domain events to new style

Daniel P. Berrange berrange at redhat.com
Tue Feb 11 16:03:07 UTC 2014


On Wed, Jan 29, 2014 at 10:49:25AM -0700, Eric Blake wrote:
> Following the patterns established by lifecycle events, this
> creates all the new RPC calls needed to pass callback IDs
> for every domain event, and changes the limits in client and
> server codes to use modern style when possible.
> 
> I've tested all combinations: both 'old client and new server'
> and 'new client and old server' continue to work with the old
> RPCs, and 'new client and new server' benefit from server-side
> filtering with the new RPCs.
> 
> * src/remote/remote_protocol.x (REMOTE_PROC_DOMAIN_EVENT_*): Add
> REMOTE_PROC_DOMAIN_EVENT_CALLBACK_* counterparts.
> * daemon/remote.c (remoteRelayDomainEvent*): Send callbackID via
> newer RPC when used with new-style registration.
> (remoteDispatchConnectDomainEventCallbackRegisterAny): Extend to
> cover all domain events.
> * src/remote/remote_driver.c (remoteDomainBuildEvent*): Add new
> Callback and Helper functions.
> (remoteEvents): Match order of RPC numbers, register new handlers.
> (remoteConnectDomainEventRegisterAny)
> (remoteConnectDomainEventDeregisterAny): Extend to cover all
> domain events.
> * src/remote_protocol-structs: Regenerate.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  daemon/remote.c              | 240 ++++++++++++++----
>  src/remote/remote_driver.c   | 581 ++++++++++++++++++++++++++++++++++---------
>  src/remote/remote_protocol.x | 155 +++++++++++-
>  src/remote_protocol-structs  |  75 ++++++
>  4 files changed, 886 insertions(+), 165 deletions(-)

ACK

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list