[libvirt] [PATCH] Fixed build with clang.

Eric Blake eblake at redhat.com
Wed Feb 12 13:31:14 UTC 2014


On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
> Two unused global variables, and DBUS_TYPE_INVALID used as a const
> char*.
> ---
>  src/phyp/phyp_driver.c             |  1 -
>  src/storage/storage_backend_scsi.c | 24 ------------------------
>  src/util/virdbus.c                 |  2 +-
>  3 files changed, 1 insertion(+), 26 deletions(-)


> +++ b/src/storage/storage_backend_scsi.c
> @@ -107,30 +107,6 @@ struct diskType {
>      unsigned long long magic;
>  };
>  
> -static struct diskType const disk_types[] = {

This is the only use of 'struct diskType'; please also remove that
declaration a couple lines earlier.

ACK with that fix.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140212/77601cc2/attachment-0001.sig>


More information about the libvir-list mailing list