[libvirt] [PATCH] [RFC] lxc: Remove !priv->cgroup case
Daniel P. Berrange
berrange at redhat.com
Fri Feb 14 14:30:32 UTC 2014
On Fri, Feb 14, 2014 at 03:21:01PM +0100, Richard Weinberger wrote:
> Currently we enforce that every container has a cgroup.
> So we can delete these two !priv->cgroup branches.
>
> Signed-off-by: Richard Weinberger <richard at nod.at>
> ---
> Hi!
>
> Maybe I miss something but I think we can delete these two !priv->cgroup branches.
> If virLXCCgroupCreate() returns NULL the LXC controller exists.
Unfortunately there's an issue that 'virLXCProcessStop' method
can be called from 'virLXCProcessStart' when container startup
fails and in this case we don't guarantee cgroup != NULL.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list