[libvirt] [PATCH v9] bhyve: add a basic driver

Roman Bogorodskiy bogorodskiy at gmail.com
Mon Feb 17 20:43:10 UTC 2014


  Daniel P. Berrange wrote:

> > +    virCommandAddArg(cmd, "-s");
> > +    virCommandAddArgFormat(cmd, "2:0,ahci-hd,%s", disk->src);
> 
> What is the '2:0' bit here ?  Is that disk controller/unit
> number ?

Quoting the manpage [1]:

pcislot[:function]

			     The pcislot value is 0 to 31 and the optional
			     function value is 0 to 7.	If not specified, the
			     function value defaults to	0.

> I'd suggest  s/INFO/DEBUG/ here and earlier.  If you want user visible
> log messages about key operations, then we should talk about what is
> needed to make  viraudit.{c,h} work on FreeBSD, and use domain_audit.c
> for this.

Will do s/INFO/DEBUG/. I'll take a look at viraudit later too.

1: http://www.freebsd.org/cgi/man.cgi?query=bhyve&apropos=0&sektion=0&manpath=FreeBSD+10.0-RELEASE&arch=default&format=html

Thanks for the review!

Roman Bogorodskiy




More information about the libvir-list mailing list