[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 5/8] Avoid unsafe use of /proc/$PID/root in LXC USB hotplug

On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:
> Rewrite lxcDomainAttachDeviceHostdevSubsysUSBLive function
> to use the virProcessRunInMountNamespace helper. This avoids
> risk of a malicious guest replacing /dev with a absolute
> symlink, tricking the driver into changing the host OS
> filesystem.
> Signed-off-by: Daniel P. Berrange <berrange redhat com>
> ---
>  src/lxc/lxc_driver.c | 73 ++++++++++++++++------------------------------------
>  1 file changed, 22 insertions(+), 51 deletions(-)

>      if (!(usb = virUSBDeviceNew(def->source.subsys.u.usb.bus,
> -                                def->source.subsys.u.usb.device, vroot)))
> +                                def->source.subsys.u.usb.device, NULL)))

It looks like all callers of virUSBDeviceNew pass NULL once this series
is over.  Can we clean things up in a followup to kill the dead
parameter?  But this patch is fine as-is.


Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]