[libvirt] [PATCH 8/8] Avoid unsafe use of /proc/$PID/root in LXC hotunplug code

Eric Blake eblake at redhat.com
Tue Feb 18 05:03:15 UTC 2014


On 02/17/2014 09:39 AM, Daniel P. Berrange wrote:
> Rewrite multiple hotunplug functions to to use the
> virProcessRunInMountNamespace helper. This avoids
> risk of a malicious guest replacing /dev with a absolute

s/a absolute/an absolute/

> symlink, tricking the driver into changing the host OS
> filesystem.

Worth mentioning the CVE number in any of these commits?  Are you
planning on backporting to stable branches, or could you use some help
on that front?

> 
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
>  src/lxc/lxc_driver.c | 79 ++++++++++++++++++++++++++--------------------------
>  1 file changed, 39 insertions(+), 40 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140217/59d11543/attachment-0001.sig>


More information about the libvir-list mailing list