[libvirt] [PATCH v9 0/7] Support keyboard device

Li Zhang zhlcindy at gmail.com
Tue Feb 18 08:58:04 UTC 2014


Hi Jan and Daniel,

Would you like to accept this patchset?

Thanks.

On 2014年02月17日 18:17, Li Zhang wrote:
> From: Li Zhang <zhlcindy at linux.vnet.ibm.com>
>
> This patchset is to add keyboard input device.
>
> For PPC64, it doesn't support a default keyboard device when the graphic
> is enabled. Libvirt supports QEMU command line as "-device VGA" which
> won't create any keyboard device for it. So it requires libvirt to add
> a default USB keyboard device for it.
>
> This patchset is to add keyboard input device and a default USB keyboard
> for PPC64.
>
> The related discussion in QEMU community:
> http://lists.nongnu.org/archive/html/qemu-devel/2013-11/msg01734.html
>
> Li Zhang (7):
>    conf: Add one interface to add default input devices
>    conf: Add a keyboard input device type
>    conf: Remove the implicit PS2 devices for non-X86 platforms
>    qemu_cap: Add USB keyboard capability
>    qemu: format qemu command line for USB keyboard
>    xen: format xen command line for USB keyboard
>    Add a default USB keyboard and USB mouse for PPC64
>
>   v9 -> v8:
>     * Move keyboard XML format to the first patch. (Jan Tomko)
>     * Correct one logic error. (Jan Tomko)
>
>   v8 -> v7:
>     * Add USB keyboard output XML format when VIR_DOMAIN_XML_MIGRATABLE isn't set. (Daniel P. && Jan Tomko)
>     * Fix test cases because of XML changes.
>
>   v7 -> v6:
>     * Corret indention errors in code. (Jan Tomko)
>     * Correct make check error in xen driver. (Jan Tomko)
>     * Split 5/6 to 2 parts, qemu and xen. (Jan Tomko)
>   v6 -> v5:
>     * Change kbd to keyboard, and correct -usbdevice parameter.
>     * Remove implicit PS/2 keyboard output in XML in case
>       older libvirtd can read it. (Jan Tomko)
>     * Remove implicit keyboard for XEN to make it safer.
>
>   v5 -> v4:
>     * Add PS/2 KBD definition in XML file. (Daniel.P.Berrange)
>     * Allow PS/2 KBD devices and set KBD default bus as PS2 for X86,
>       USB for non-x86. (Daniel.P.Berrange)
>     * Add an implicit PS/2 KBD as PS/2 mouse. (Danniel.P.Berrange)
>
>   v4 -> v3:
>     * Don't remove PS2 mouse device for other virtualization drivers (Jan Tomko).
>
>   v3 -> v2:
>     * Handle the KBD device type in xen and QEMU driver. (Daniel.P.Berrange)
>     * Remove PS2 mouse device for non-X86 platforms.
>     * Move virDomainDefMaybeAddInput to a new patch. (Jan Tomko)
>     * Replace VIR_REALLOC_N with VIR_APPEND_ELEMENT. (Jan Tomoko)
>     * Fix several typos.                             (Jan Tomoko)
>     * Add a virReportError when QEMU_CAPS_DEVICE_USB_KBD can't be gotten. (Jan Tomoko)
>
>   v2 -> v1:
>     * change ifs to switch clause.
>     * reconstruct the patches
>
>   docs/schemas/domaincommon.rng                      |   1 +
>   src/conf/domain_conf.c                             | 116 ++++++++++++++-------
>   src/conf/domain_conf.h                             |   5 +
>   src/libvirt_private.syms                           |   1 +
>   src/qemu/qemu_capabilities.c                       |   3 +
>   src/qemu/qemu_capabilities.h                       |   1 +
>   src/qemu/qemu_command.c                            |  41 ++++++--
>   src/qemu/qemu_domain.c                             |  23 +++-
>   src/util/virarch.h                                 |   2 +
>   src/xenxs/xen_sxpr.c                               |  27 +++--
>   src/xenxs/xen_xm.c                                 |  30 ++++--
>   tests/qemucapabilitiesdata/caps_1.2.2-1.caps       |   1 +
>   tests/qemucapabilitiesdata/caps_1.3.1-1.caps       |   1 +
>   tests/qemucapabilitiesdata/caps_1.4.2-1.caps       |   1 +
>   tests/qemucapabilitiesdata/caps_1.5.3-1.caps       |   1 +
>   tests/qemucapabilitiesdata/caps_1.6.0-1.caps       |   1 +
>   tests/qemucapabilitiesdata/caps_1.6.50-1.caps      |   1 +
>   tests/qemuhelptest.c                               |   8 ++
>   ...qemuhotplug-console-compat-2+console-virtio.xml |   1 +
>   .../qemuxml2argv-console-compat-2.xml              |   1 +
>   .../qemuxml2argv-graphics-listen-network.xml       |   1 +
>   .../qemuxml2argv-graphics-listen-network2.xml      |   1 +
>   .../qemuxml2argv-graphics-sdl-fullscreen.xml       |   1 +
>   .../qemuxml2argvdata/qemuxml2argv-graphics-sdl.xml |   1 +
>   .../qemuxml2argv-graphics-spice-compression.xml    |   1 +
>   .../qemuxml2argv-graphics-spice-qxl-vga.xml        |   1 +
>   .../qemuxml2argv-graphics-spice-timeout.xml        |   2 +
>   .../qemuxml2argv-graphics-spice.xml                |   1 +
>   .../qemuxml2argv-graphics-vnc-policy.xml           |   1 +
>   .../qemuxml2argv-graphics-vnc-sasl.xml             |   1 +
>   .../qemuxml2argv-graphics-vnc-socket.xml           |   1 +
>   .../qemuxml2argv-graphics-vnc-tls.xml              |   1 +
>   .../qemuxml2argv-graphics-vnc-websocket.xml        |   1 +
>   .../qemuxml2argvdata/qemuxml2argv-graphics-vnc.xml |   1 +
>   tests/qemuxml2argvdata/qemuxml2argv-input-xen.xml  |   1 +
>   .../qemuxml2argv-net-bandwidth.xml                 |   1 +
>   tests/qemuxml2argvdata/qemuxml2argv-pci-bridge.xml |   1 +
>   .../qemuxml2argvdata/qemuxml2argv-pseries-disk.xml |   3 +-
>   .../qemuxml2argv-pseries-usb-kbd.args              |   9 ++
>   .../qemuxml2argv-pseries-usb-kbd.xml               |  19 ++++
>   .../qemuxml2argv-serial-spiceport.xml              |   1 +
>   tests/qemuxml2argvtest.c                           |   3 +
>   .../qemuxml2xmlout-graphics-listen-network2.xml    |   1 +
>   .../qemuxml2xmlout-graphics-spice-timeout.xml      |   1 +
>   tests/vmx2xmldata/vmx2xml-graphics-vnc.xml         |   1 +
>   45 files changed, 256 insertions(+), 66 deletions(-)
>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.args
>   create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-pseries-usb-kbd.xml
>




More information about the libvir-list mailing list