[libvirt] [libvirt-python PATCH] generator: Skip exporting only sentinels
Daniel P. Berrange
berrange at redhat.com
Thu Feb 20 16:19:54 UTC 2014
On Thu, Feb 20, 2014 at 05:15:08PM +0100, Martin Kletzander wrote:
> When enum type has '_LAST' in its name, but is not the last type in
> that enum, it's skipped even though it shouldn't be. Currently, this
> is the case for only VIR_NETWORK_UPDATE_COMMAND_ADD_LAST inside an
> enum virNetworkUpdateCommand.
>
> Also, since _LAST types can have other enums instead of values, that
> needs to be filtered out using a try-except when converting the value.
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
> generator.py | 19 ++++++++++++++-----
> 1 file changed, 14 insertions(+), 5 deletions(-)
ACK.
Perhaps also extend sanitytest.py to check enums ?
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list