[libvirt] [PATCH 4/4] Generate a unique journald log for QEMU capabilities failure
Eric Blake
eblake at redhat.com
Fri Feb 21 17:45:15 UTC 2014
On 02/21/2014 10:31 AM, Daniel P. Berrange wrote:
> When probing QEMU capabilities fails for a binary generate a
> log message with MESSAGE_ID==8ae2f3fb-2dbe-498e-8fbd-012d40afa361.
I'd expect this value to be documented somewhere in the html pages.
>
> Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
> ---
> src/qemu/qemu_capabilities.c | 28 ++++++++++++++++++++++++++--
> 1 file changed, 26 insertions(+), 2 deletions(-)
>
> diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.c
> index d618b3f..9d5f026 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -2754,6 +2754,26 @@ cleanup:
> }
>
>
> +#define MESSAGE_ID_CAPS_PROBE_FAILURE "8ae2f3fb-2dbe-498e-8fbd-012d40afa361"
> +
> +static void virQEMUCapsLogProbeFailure(const char *binary)
Style - shouldn't this take two lines?
> +
> + virLogMessage(VIR_LOG_FROM_FILE,
> + VIR_LOG_WARN,
> + __FILE__, __LINE__, __func__,
> + meta,
> + "Failed to probe capabilities for %s: %s",
> + binary, err && err->message ? err->message : "<unknown failure>");
Should either of these strings be marked with _()?
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140221/7f417a7f/attachment-0001.sig>
More information about the libvir-list
mailing list