[libvirt] [PATCH 2/7] conf: handle null pointer in virNetDevVlanFormat

Michal Privoznik mprivozn at redhat.com
Mon Feb 24 16:46:14 UTC 2014


On 21.02.2014 14:58, Laine Stump wrote:
> Other *Format() functions (e.g. virNetDevBandwidthFormat()) return
> with no action when called with a NULL *Def pointer. This makes
> virNetDevVlanFormat() consistent with that behavior.
> ---
>   src/conf/netdev_vlan_conf.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/conf/netdev_vlan_conf.c b/src/conf/netdev_vlan_conf.c
> index f58b4b8..dbe203e 100644
> --- a/src/conf/netdev_vlan_conf.c
> +++ b/src/conf/netdev_vlan_conf.c
> @@ -1,5 +1,5 @@
>   /*
> - * Copyright (C) 2009-2013 Red Hat, Inc.
> + * Copyright (C) 2009-2014 Red Hat, Inc.
>    *
>    * This library is free software; you can redistribute it and/or
>    * modify it under the terms of the GNU Lesser General Public
> @@ -144,7 +144,7 @@ virNetDevVlanFormat(const virNetDevVlan *def, virBufferPtr buf)
>   {
>       size_t i;
>
> -    if (def->nTags == 0)
> +    if (!(def && def->nTags))
>           return 0;
>
>       if (!def->tag) {
>

ACK

Michal




More information about the libvir-list mailing list