[libvirt] [PATCH] network: unplug bandwidth and call networkRunHook only when appropriate

Eric Blake eblake at redhat.com
Tue Feb 25 23:42:52 UTC 2014


On 02/25/2014 08:47 AM, Laine Stump wrote:
> According to commit b4e0299dm if networkAllocateActualDevice() was
> successful, it will *always* allocate an iface->data.network.actual,
> so we can use this during networkReleaseActualDevice() to know if
> there is really anything to undo. We were properly using this
> information to only decrement the network connections counter if it
> had previously been incremented, but we were unconditionally
> unplugging bandwidth and calling the "unplugged" network hook for
> *all* interfaces (during qemuProcessStop()) whether they had been
> previously plugged or not. This caused problems if a domain failed to
> start at some time prior to all interfaces being allocated. (I
> encountered this when an interface had a bandwidth floor set but no
> inbound QoS).
> 
> This patch changes both the call to networkUnplugBandwidth() and the
> call to networkRunHook() to only be called if there was a previous
> call to "plug" for the same interface.
> ---
>  src/network/bridge_driver.c | 17 +++++++++--------
>  1 file changed, 9 insertions(+), 8 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140225/21b979b1/attachment-0001.sig>


More information about the libvir-list mailing list