[libvirt] [PATCH] network: unplug bandwidth and call networkRunHook only when appropriate

Michal Privoznik mprivozn at redhat.com
Wed Feb 26 10:47:23 UTC 2014


On 25.02.2014 16:47, Laine Stump wrote:
> According to commit b4e0299dm if networkAllocateActualDevice() was

The 'm' at the end of has is a typo. s/dm/d,/

> successful, it will *always* allocate an iface->data.network.actual,
> so we can use this during networkReleaseActualDevice() to know if
> there is really anything to undo. We were properly using this
> information to only decrement the network connections counter if it
> had previously been incremented, but we were unconditionally
> unplugging bandwidth and calling the "unplugged" network hook for
> *all* interfaces (during qemuProcessStop()) whether they had been
> previously plugged or not. This caused problems if a domain failed to
> start at some time prior to all interfaces being allocated. (I
> encountered this when an interface had a bandwidth floor set but no
> inbound QoS).
>
> This patch changes both the call to networkUnplugBandwidth() and the
> call to networkRunHook() to only be called if there was a previous
> call to "plug" for the same interface.
> ---
>   src/network/bridge_driver.c | 17 +++++++++--------
>   1 file changed, 9 insertions(+), 8 deletions(-)

ACK

Michal




More information about the libvir-list mailing list