[libvirt] [PATCHv2 1/10] nwfilter: make ignoring non-zero status easier to follow

Laine Stump laine at laine.org
Wed Feb 26 11:18:30 UTC 2014


On 02/26/2014 01:37 AM, Eric Blake wrote:
> While auditing all callers of virCommandRun, I noticed that nwfilter
> code never paid attention to commands with a non-zero status; they
> were merely passing a pointer to avoid spamming the logs with a
> message about commands that might indeed fail.  But proving this
> required chasing through a lot of code; refactoring things to
> localize the decision of whether to ignore non-zero status makes
> it easier to prove that later changes to virFork don't negatively
> affect this code.
>
> While at it, I also noticed that ebiptablesRemoveRules would
> actually report success if the child process failed for a
> reason other than non-zero status, such as OOM.

ACK.




More information about the libvir-list mailing list