[libvirt] [PATCH 06/24] maint: reset error on entrance to public API
John Ferlan
jferlan at redhat.com
Thu Jan 2 19:11:46 UTC 2014
On 12/28/2013 11:11 AM, Eric Blake wrote:
> We document that calling any public API wipes out all prior
> libvirt errors in the same thread; but weren't obeying this
> style in a few functions.
>
> * src/libvirt.c (virGetVersion, virConnectRef, virDomainRef)
> (virDomainGetSecurityLabel, virDomainGetSecurityLabelList)
> (virDomainSetMetadata, virDomainGetMetadata)
> (virNodeGetSecurityModel, virNetworkRef, virInterfaceRef)
> (virStoragePoolRef, virStorageVolRef, virNodeDeviceGetName)
> (virNodeDeviceRef, virSecretRef, virStreamRef, virNWFilterRef)
> (virDomainSnapshotRef): Reset error on entrance.
> (do_open): Drop redundant error reset.
> * src/libvirt-qemu.c (virDomainQemuAgentCommand): Likewise.
> * src/libvirt-lxc.c (virDomainLxcEnterNamespace)
> (virDomainLxcEnterSecurityLabel): Likewise.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> src/libvirt-lxc.c | 4 ++++
> src/libvirt-qemu.c | 4 ++++
> src/libvirt.c | 37 +++++++++++++++++++++++++++++++++++--
> 3 files changed, 43 insertions(+), 2 deletions(-)
>
ACK
just making sure - is there any side effect to calls to virConnectRef()
being called through the lxc reboot or qemu reconnect paths?
John
More information about the libvir-list
mailing list