[libvirt] [PATCH 10/24] maint: improve VIR_ERR_INVALID_CONN usage
John Ferlan
jferlan at redhat.com
Thu Jan 2 23:32:35 UTC 2014
On 12/28/2013 11:11 AM, Eric Blake wrote:
> The datatype.c object checks could result in a message like:
>
> error: invalid connection pointer in no connection
>
> This consolidates all clients of this message to have uniform contents:
>
> error: invalid connection pointer in someFunc
>
> * src/datatypes.h (virCheckConnectReturn)
> (virCheckConnectGoto): New macros.
> * src/datatypes.c: Use new macro.
> * src/libvirt-qemu.c (virDomainQemuAttach): Likewise.
> (virLibConnError): Delete unused macro.
> * src/libvirt-lxc.c (virLibConnError): Likewise.
> * src/libvirt.c: Use new macro throughout.
> * docs/api_extension.html.in: Modernize documentation.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> docs/api_extension.html.in | 7 +-
> src/datatypes.c | 86 ++---
> src/datatypes.h | 19 ++
> src/libvirt-lxc.c | 4 -
> src/libvirt-qemu.c | 11 +-
> src/libvirt.c | 783 +++++++--------------------------------------
> 6 files changed, 178 insertions(+), 732 deletions(-)
>
ACK
John
More information about the libvir-list
mailing list