[libvirt] [PATCH 17/24] maint: improve VIR_ERR_INVALID_STORAGE_VOL usage
John Ferlan
jferlan at redhat.com
Fri Jan 3 00:28:33 UTC 2014
On 12/28/2013 11:11 AM, Eric Blake wrote:
> For storage volume validation, we weren't consistent on
> whether to use VIR_FROM_NONE or VIR_FROM_STORAGE. Similar
> to previous patches, use a common macro to make it nicer.
>
> virStorageVolCreateXMLFrom allows cross-connection cloning,
> where the error is reported against the connection of the
> destination pool.
>
> * src/datatypes.h (virCheckStorageVolReturn)
> (virCheckStorageVolGoto): New macros.
> (VIR_IS_STORAGE_VOL, VIR_IS_CONNECTED_STORAGE_VOL): Drop
> unused macros.
> * src/libvirt.c: Use macro throughout.
> (virLibStorageVolError): Drop unused macro.
>
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
> src/datatypes.h | 29 +++++++++++++--
> src/libvirt.c | 112 ++++++++++++--------------------------------------------
> 2 files changed, 49 insertions(+), 92 deletions(-)
>
Same as previous w/r/t GetName and GetKey here.
ACK
John
More information about the libvir-list
mailing list