[libvirt] [PATCH 22/24] maint: improve VIR_ERR_INVALID_DOMAIN_SNAPSHOT usage
John Ferlan
jferlan at redhat.com
Fri Jan 3 01:38:54 UTC 2014
On 01/02/2014 07:53 PM, John Ferlan wrote:
>
>
> On 12/28/2013 11:11 AM, Eric Blake wrote:
>> The existing check of domain snapshots validated that they
>> point to a domain, but did not validate that the domain
>> points to a connection, even though any errors blindly assume
>> the connection is valid. For consistency with previous
>> patches, continue the trend of using a common macro. For
>> now, we don't need virCheckDomainSnapshotGoto().
>>
>> * src/datatypes.h (virCheckDomainSnapshotReturn): New macro.
>> (VIR_IS_SNAPSHOT, VIR_IS_DOMAIN_SNAPSHOT):
>> Drop unused macros.
>> * src/libvirt.c: Use macro throughout.
>> (virLibDomainSnapshotError): Drop unused macro.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>> src/datatypes.h | 18 +++++++--
>> src/libvirt.c | 118 +++++++++++---------------------------------------------
>> 2 files changed, 36 insertions(+), 100 deletions(-)
>>
>
> Still paying attention (barely)... GetName, GetUUID, and GetUUIDString
> will all now require the connection
>
Guess I wasn't paying that close attention as this was meant for 21/24 :-)
John
>
> ACK
>
> John
>
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>
More information about the libvir-list
mailing list