[libvirt] [PATCH] Fix argument order at qemuMigrationPerformJob().

Ján Tomko jtomko at redhat.com
Tue Jan 7 09:00:49 UTC 2014


On 01/07/2014 02:03 AM, Minoru Usui wrote:
> Hi, everyone.
> 
> I found a small bug at qemuMigrationPerformJob().
> The order of argument, @listenAddress and @cookiein, should be changed place,
> because these order are mismatched caller and callee.
> 
> Signed-off-by: Minoru Usui <usui at mxm.nes.nec.co.jp>
> ---
>  src/qemu/qemu_migration.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

ACK.

This breaks the use of listen address for p2p migration and ignores the input
cookie for migration protocols older than v3.

Introduced along with the listen address parameter in
c4ac7ef (describe --contains: v1.1.4-rc1~141).

Jan

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140107/f39baada/attachment-0001.sig>


More information about the libvir-list mailing list