[libvirt] [PATCH] lxc_controller: Fix error message on missing --handshakefd

Eric Blake eblake at redhat.com
Tue Jan 7 15:12:03 UTC 2014


On 01/07/2014 07:56 AM, Michal Privoznik wrote:
> The argument is --handshakefd not --handshake.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/lxc/lxc_controller.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

ACK.

> 
> diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c
> index 1b43bd2..a2ae599 100644
> --- a/src/lxc/lxc_controller.c
> +++ b/src/lxc/lxc_controller.c
> @@ -2365,7 +2365,7 @@ int main(int argc, char *argv[])
>      }
>  
>      if (handshakeFd < 0) {
> -        fprintf(stderr, "%s: missing --handshake argument for container PTY\n",
> +        fprintf(stderr, "%s: missing --handshakefd argument for container PTY\n",

Not in this patch, but we should probably add _() marking to all the
error messages in main() after the point of our textdomain() call
earlier, so that a user typing the command line will get a localized
error message.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140107/48d9183c/attachment-0001.sig>


More information about the libvir-list mailing list