[libvirt] [PATCH 0/2] v2: spice: expose the disable file transfer option

Francesco Romani fromani at redhat.com
Tue Jan 7 19:04:31 UTC 2014


Here it is the second version of the patch which export the spice agent
disable file transfer.

I followed Eric's advice and added detection of the support in QEMU in
the first patch; the second builds upon the first and exports the
support to libvirt.

The XML format is intentionally similar to the 'clipboard' element,
I thought the share enough similiarities; however, suggestions
are more than welcome here.

Please also feel free to suggest how to extend the testing, and if
what was added here is enough. As everyone probably already noticed
it's my first libvirt contribution; I tried to follow HACKING's
advice caredully but I can have missed something (more).

Best regards,

Francesco Romani (2):
  spice: detect if qemu can disable file transfer
  spice: expose the QEMU disable file transfer option

 docs/formatdomain.html.in                          |  8 +++++
 docs/schemas/domaincommon.rng                      | 11 ++++++
 src/conf/domain_conf.c                             | 31 ++++++++++++++++-
 src/conf/domain_conf.h                             | 10 ++++++
 src/libvirt_private.syms                           |  2 ++
 src/qemu/qemu_capabilities.c                       |  5 ++-
 src/qemu/qemu_capabilities.h                       |  1 +
 src/qemu/qemu_command.c                            |  9 +++++
 tests/qemucapabilitiesdata/caps_1.6.0-1.caps       |  1 +
 tests/qemucapabilitiesdata/caps_1.6.50-1.caps      |  1 +
 ...emuxml2argv-graphics-spice-agent-file-xfer.args |  9 +++++
 ...qemuxml2argv-graphics-spice-agent-file-xfer.xml | 40 ++++++++++++++++++++++
 tests/qemuxml2argvtest.c                           |  6 ++++
 13 files changed, 132 insertions(+), 2 deletions(-)
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-agent-file-xfer.args
 create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-graphics-spice-agent-file-xfer.xml

-- 
1.8.4.2




More information about the libvir-list mailing list