[libvirt] [libvirt-java] [PATCH] Avoid calling processError for functions that cannot fail
Claudio Bley
cbley at av-test.de
Wed Jan 8 15:31:38 UTC 2014
At Wed, 8 Jan 2014 16:25:30 +0100,
Claudio Bley wrote:
>
> The libvirt functions virNodeDeviceNumOfCaps, virNodeDeviceGetParent
> and virNodeDeviceListCaps never indicate an error because they do not
> fail.
> ---
> src/main/java/org/libvirt/Device.java | 19 ++++++-------------
> src/main/java/org/libvirt/jna/Libvirt.java | 2 +-
> 2 files changed, 7 insertions(+), 14 deletions(-)
>
> diff --git a/src/main/java/org/libvirt/jna/Libvirt.java b/src/main/java/org/libvirt/jna/Libvirt.java
> index b026b04..a2bf42e 100644
> --- a/src/main/java/org/libvirt/jna/Libvirt.java
> +++ b/src/main/java/org/libvirt/jna/Libvirt.java
> @@ -281,7 +281,7 @@ public interface Libvirt extends Library {
> String virNodeDeviceGetName(DevicePointer virDevicePointer);
> String virNodeDeviceGetParent(DevicePointer virDevicePointer);
> int virNodeDeviceNumOfCaps(DevicePointer virDevicePointer);
> - int virNodeDeviceListCaps(DevicePointer virDevicePointer, String[] names, int maxNames);
> + int virNodeDeviceListCaps(DevicePointer virDevicePointer, Pointer[] names, int maxNames);
> String virNodeDeviceGetXMLDesc(DevicePointer virDevicePointer);
> int virNodeDeviceFree(DevicePointer virDevicePointer);
> int virNodeDeviceDettach(DevicePointer virDevicePointer);
I just realized that this hunk does not belong to the patch. Please
ignore it when reviewing.
Claudio
--
AV-Test GmbH, Henricistraße 20, 04155 Leipzig, Germany
Phone: +49 341 265 310 19
Web:<http://www.av-test.org>
Eingetragen am / Registered at: Amtsgericht Stendal (HRB 114076)
Geschaeftsfuehrer (CEO): Andreas Marx, Guido Habicht, Maik Morgenstern
More information about the libvir-list
mailing list