[libvirt] [PATCH] Make sure AC_ARG_WITH is always executed

Guido Günther agx at sigxcpu.org
Wed Jan 8 16:51:49 UTC 2014


On Tue, Jan 07, 2014 at 04:19:14PM -0700, Eric Blake wrote:
> On 01/07/2014 04:10 PM, Guido Günther wrote:
> > ---
> > I'm not sure whether it's good autoconf style to have AC_ARG_WITH in a
> > conditional so this patch moves it out.
> 
> Much of the code within AC_ARG_WITH gets executed unconditionally
> (because it gets hoisted to earlier parts of the configure than where
> you actually invoked it in configure.ac), so you are correct that using
> it unconditionally is better style.  ACK.
Pushed now. Thanks.
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140108/37b8ecc5/attachment-0001.sig>


More information about the libvir-list mailing list