[libvirt] [PATCH 3/6] Fix possible memory leak in util/virxml.c

Pavel Hrdina phrdina at redhat.com
Mon Jan 13 16:12:09 UTC 2014

A "xmlstr" string may not be assigned into a "doc" pointer and it
could cause memory leak. To fix it if the "doc" pointer is NULL and
the "xmlstr" string is not assigned we should free it.

This has been found by coverity.

Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
 src/util/virxml.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/util/virxml.c b/src/util/virxml.c
index 5852374..dd530a6 100644
--- a/src/util/virxml.c
+++ b/src/util/virxml.c
@@ -1047,6 +1047,8 @@ virXMLExtractNamespaceXML(xmlNodePtr root,
     if (doc)
         *doc = xmlstr;
+    else
+        VIR_FREE(xmlstr);
     return ret;

More information about the libvir-list mailing list