[libvirt] [libvirt-glib 5/5] gconfig: Fix removal of GVirConfigDomainCpu from domains

Christophe Fergeau cfergeau at redhat.com
Tue Jan 21 10:42:58 UTC 2014


A wrong precondition in gvir_config_domain_set_cpu() would reject NULL
GVirConfigDomainCpus instead of accepting them.
---
 libvirt-gconfig/libvirt-gconfig-domain.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c b/libvirt-gconfig/libvirt-gconfig-domain.c
index 702669e..064f307 100644
--- a/libvirt-gconfig/libvirt-gconfig-domain.c
+++ b/libvirt-gconfig/libvirt-gconfig-domain.c
@@ -857,7 +857,7 @@ void gvir_config_domain_set_cpu(GVirConfigDomain *domain,
                                 GVirConfigDomainCpu *cpu)
 {
     g_return_if_fail(GVIR_CONFIG_IS_DOMAIN(domain));
-    g_return_if_fail(cpu != NULL || GVIR_CONFIG_IS_DOMAIN_CPU(cpu));
+    g_return_if_fail(cpu == NULL || GVIR_CONFIG_IS_DOMAIN_CPU(cpu));
 
     gvir_config_object_attach_replace(GVIR_CONFIG_OBJECT(domain),
                                       "cpu",
-- 
1.8.4.2




More information about the libvir-list mailing list