[libvirt] [PATCHv2 8/9] qemu: snapshot: Switch snapshot file deletion to the new storage API

Eric Blake eblake at redhat.com
Mon Jan 27 22:36:53 UTC 2014


On 01/16/2014 06:14 AM, Peter Krempa wrote:
> Use the new storage conversion APIs to delete garbage left behind after
> a failed snapshot attempt using the storage driver.
> ---
>  src/qemu/qemu_driver.c | 60 ++++++++++++++++++++++++++++++++++++++------------
>  1 file changed, 46 insertions(+), 14 deletions(-)
> 

> +    switch (origdisk->type) {
> +    case VIR_DOMAIN_DISK_TYPE_BLOCK:
> +    case -1: /* type was not provided in snapshot conf */

Is this case leftover that can be removed after your earlier refactoring?

ACK with that fixed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140127/7cf4734a/attachment-0001.sig>


More information about the libvir-list mailing list