[libvirt] [PATCH] maint: use $(SED) instead of sed for syntax-check

Roman Bogorodskiy bogorodskiy at gmail.com
Tue Jan 28 07:28:13 UTC 2014

  Paul Eggert wrote:

> On 01/27/2014 01:03 PM, Eric Blake wrote:
> > I'd like some feedback from the gnulib
> > community if favoring $(SED) is the right thing to do, or if I should
> > just rewrite libvirt's rules to stick to portable sed constructs.
> My kneejerk reaction is that we'd probably have fewer problems using 
> '$(SED)' everywhere in a makefile, rather than using '$(SED)' some 
> places and 'sed' in others, because it'd be one less 'sed' 
> implementation to worry about.

Yes, that was the idea. That's why I replaced all the usage of 'sed' even
though not all of them are non-portable, as Eric pointed.

For sure, using portable regexps is better way, but I don't know how
much of effort that would be.

Roman Bogorodskiy

More information about the libvir-list mailing list