[libvirt] [PATCHv2 9/9] qemu: snapshot: Add support for external active snapshots on gluster
Peter Krempa
pkrempa at redhat.com
Tue Jan 28 13:07:05 UTC 2014
On 01/27/14 23:40, Eric Blake wrote:
> On 01/16/2014 06:14 AM, Peter Krempa wrote:
>> Add support for gluster backed images as sources for snapshots in the
>> qemu driver. This will also simplify adding further network backed
>> volumes as sources for snapshot in case qemu will support them.
>> ---
>> docs/formatsnapshot.html.in | 4 +-
>> src/qemu/qemu_command.c | 2 +-
>> src/qemu/qemu_command.h | 9 ++++
>> src/qemu/qemu_driver.c | 113 +++++++++++++++++++++++++++++++++++++++++---
>> 4 files changed, 118 insertions(+), 10 deletions(-)
>
>>
>> Libvirt currently supports the <code>type</code> element in the qemu
>> - driver and supported values are <code>file</code> and
>> - <code>block</code> <span class="since">(since 1.2.2)</span>.
>> + driver and supported values are <code>file</code>, <code>block</code>
>> + and <code>gluster</code> <span class="since">(since 1.2.2)</span>.
>
> Rather, type <code>network</code> with a protocol of gluster.
>
>
>> +
>> + return qemuGetDriveSourceString(qemuSnapshotDiskGetActualType(disk),
>
> qemuSnapshotDiskGetActualType(disk) is now just a fancy wrapper around
> disk->type, since 4/9. Do we even need that function, or can we just
> delete it and simplify all callers?
Currently the function isn't useful. I'd like to keep it in case we will
support snapshots on type='volume' in the future.
>
> ACK with those fixes.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140128/ace8b4a1/attachment-0001.sig>
More information about the libvir-list
mailing list