[libvirt] [PATCHv3 3/4] Simplify linuxNodeGetCPUStats
Ján Tomko
jtomko at redhat.com
Tue Jan 28 14:30:08 UTC 2014
On 01/28/2014 08:50 AM, Ján Tomko wrote:
> On 01/27/2014 05:16 PM, Eric Blake wrote:
>> On 01/22/2014 06:37 AM, Ján Tomko wrote:
>>> Split out the repetitive code.
>>> ---
>>> src/nodeinfo.c | 77 +++++++++++++++++++++++-----------------------------------
>>> 1 file changed, 30 insertions(+), 47 deletions(-)
>>>
>>
>> ACK.
>>
>>
>>> @@ -722,51 +734,22 @@ linuxNodeGetCPUStats(FILE *procstat,
>>> continue;
>>> }
>>>
>>> - for (i = 0; i < *nparams; i++) {
>>> - virNodeCPUStatsPtr param = ¶ms[i];
>>
>> The old loop terminates early if *nparams < 4.
>>
>
> We can't get there with *nparams != 4:
> if ((*nparams) != LINUX_NB_CPU_STATS) {
> virReportInvalidArg(*nparams,
> _("nparams in %s must be equal to %d"),
> __FUNCTION__, LINUX_NB_CPU_STATS);
> goto cleanup;
> }
>
I've pushed this along with 4/3.
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140128/81f5b1a9/attachment-0001.sig>
More information about the libvir-list
mailing list