[libvirt] [PATCH v3 2/4] Fix pthread_sigmask check for mingw32 without winpthreads

Daniel P. Berrange berrange at redhat.com
Wed Jan 29 14:53:52 UTC 2014


On Fedora 19 and older the pthreads impl provided with
mingw does not have any pthread_sigmask impl at all. The
configure.ac check was not distinguishing this scenario
from that of a broken pthread_sigmask impl, so was
mistakenly enabling the libvirt workaround even when it
was not needed. This in turn conflicted with the gnulib
provided pthread_sigmask impl.

Signed-off-by: Daniel P. Berrange <berrange at redhat.com>
---
 configure.ac | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 3a70375..20d6202 100644
--- a/configure.ac
+++ b/configure.ac
@@ -285,8 +285,10 @@ AC_CACHE_CHECK([whether pthread_sigmask does anything],
     #include <sys/types.h>
     #include <signal.h>
   ]], [[
-   int (*foo)(int, const sigset_t *, sigset_t *) = &pthread_sigmask;
-   return !foo;
+    #ifdef pthread_sigmask
+    int (*foo)(int, const sigset_t *, sigset_t *) = &pthread_sigmask;
+    return !foo;
+    #endif
   ]])], [lv_cv_pthread_sigmask_works=yes], [lv_cv_pthread_sigmask_works=no])])
 if test "x$lv_cv_pthread_sigmask_works" != xyes; then
   AC_DEFINE([FUNC_PTHREAD_SIGMASK_BROKEN], [1],
-- 
1.8.4.2




More information about the libvir-list mailing list