[libvirt] [PATCH for 1.2.6] securityselinuxlabeltest: Don't create dummy file in the srcdir

Ján Tomko jtomko at redhat.com
Tue Jul 1 13:00:06 UTC 2014


On 07/01/2014 02:58 PM, Michal Privoznik wrote:
> At the very beginning of the test we check if the underlying
> filesystem supports extended attributes as they are used to store fake
> SELinux labels. In order to check that, a dummy file is created and
> semi-random attribute is set. However, the file is created under:
> 
>   abs_srcdir "/securityselinuxlabeldata/testxattr"
> 
> which has two problems: abs_srcdir is not required to be writable, so
> it should have been abs_builddir. The second one is - there's no
> "securityselinuxlabeldata" folder under abs_builddir. The problem was
> introduced in caf164f1.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tests/securityselinuxlabeltest.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

ACK

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140701/25197ff8/attachment-0001.sig>


More information about the libvir-list mailing list