[libvirt] securityselinuxlabeltest test fails on v1.2.5

[Michal Privoznik]

On 30.06.2014 21:46, Scott Sullivan wrote:
> On 06/26/2014 05:36 PM, Eric Blake wrote:
>> On 06/26/2014 09:38 AM, Scott Sullivan wrote:
>>> On 06/26/2014 10:09 AM, Ján Tomko wrote:
>>>> On 06/26/2014 03:56 PM, Scott Sullivan wrote:
>>>>>    1) Labelling
>>>>> "disks"                                                 ...
>>>>> internal error: File
>>>>> /home/rpmbuild/packages/libvirt/tests/securityselinuxlabeldata/plain.raw
>>>>>
>>>>> context 'EOPNOTSUPP' did not match epected
>>>>> 'system_u:object_r:svirt_image_t:s0:c41,c264'
>>>> There was a patch skipping the test if setting xattrs is not
>>>> supported, but
>>>> it's not merged yet:
>>>>
>>>> https://www.redhat.com/archives/libvir-list/2014-June/msg00402.html
>>>>
>>>> Jan
>>>>
>>> Jan,
>>>
>>> Thanks for this. I've applied the patch and it has solved my issues.
>> Now pushed; it missed 1.2.6-rc1, but should be in rc2, if you want to
>> test that in a couple days.
>>
>
> Hi Eric.
>
> I've tested the v1.2.6-rc2 git tag, im getting this build error:
>
>    CC     util/libvirt_util_la-virnuma.lo
> util/virnuma.c: In function 'virNumaNodeIsAvailable':
> util/virnuma.c:428: error: 'numa_nodes_ptr' undeclared (first use in
> this function)
> util/virnuma.c:428: error: (Each undeclared identifier is reported only
> once
> util/virnuma.c:428: error: for each function it appears in.)
> make[3]: *** [util/libvirt_util_la-virnuma.lo] Error 1
> make[3]: Leaving directory `/home/rpmbuild/packages/libvirt/src'
> make[2]: *** [all] Error 2
> make[2]: Leaving directory `/home/rpmbuild/packages/libvirt/src'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/rpmbuild/packages/libvirt'
> make: *** [all] Error 2
> error: Bad exit status from /var/tmp/rpm-tmp.3Gu7nd (%build)
>
> Build works fine on tag v1.2.5-maint.

This is very interesting, because it's my code (it's not interesting 
because of that :P ). I mean, when I was writing the code I checked 
numactl sources to see if 'numa_nodes_ptr' and 'numa_bitmask_isbitset' 
symbols were introduced in the same release. And they were indeed. Well, 
the latter accepts the former as an argument, so checking for the latter 
should be enough even if the symbols were not introduced at once. But 
how on earth is numactl exporting the isbitset when numa_nodes_ptr is 
not exported?

Michal