[libvirt] [PATCH v4 0/5] Another version of active commit

Eric Blake eblake at redhat.com
Tue Jul 1 22:12:21 UTC 2014

On 06/23/2014 05:30 PM, Eric Blake wrote:
> Rebased to latest libvirt.git, and still waiting on Jeff's qemu
> patches to go into qemu.git before I can push any of these,
> https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg04060.html
> but reposting because of a feature Adam had been requesting:
> Patch 3/5 is new, and adds a new <activecommit/> marker to the
> 'virsh capabilities' output if qemu is detected as supporting
> active commit.  I've resolved some of Peter's review comments
> in patches 1 and 2 (patch 1 underwent a bit of a rewrite to
> differentiate the qemu capability probe from normal use of the
> interface, and 2 dropped mention of RHEL 6.3 except in the
> commit message).  At this point, I haven't altered 4 or 5,
> although I still need to do something about getting a persistent
> domain definition updated after a pivot changes the file in
> use by a running domain.

qemu.git (and therefore the upcoming qemu 2.1 release) now has
everything we need:

commit 7676e2c597000eff3a7233b40cca768b358f9bc9
Author: Jeff Cody <jcody at redhat.com>
Date:   Mon Jun 30 15:14:15 2014 +0200

    block: make 'top' argument to block-commit optional

    Now that active layer block-commit is supported, the 'top' argument
    no longer needs to be mandatory.

    Change it to optional, with the default being the active layer in the
    device chain.

    [kwolf: Rebased and resolved conflict in tests/qemu-iotests/040]

    Reviewed-by: Eric Blake <eblake at redhat.com>
    Reviewed-by: Benoit Canet <benoit at irqsave.net>
    Signed-off-by: Jeff Cody <jcody at redhat.com>
    Signed-off-by: Kevin Wolf <kwolf at redhat.com>
    Signed-off-by: Stefan Hajnoczi <stefanha at redhat.com>

but I'd rather wait until after the 1.2.6 release to push this series
since I still don't have persistent XML manipulation working, and since
we may want to rework how feature advertisement works.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140701/b6914662/attachment-0001.sig>

More information about the libvir-list mailing list