[libvirt] [PATCH 1/6] util: storage: Add helper to determine whether storage is local

[Peter Krempa]

On 07/03/14 15:25, Ján Tomko wrote:
> On 07/03/2014 12:04 PM, Peter Krempa wrote:
>> There's a lot of places where we skip doing actions based on the
>> locality of given storage type. The usual pattern is to skip it if:
>>
>> virStorageSourceGetActualType(src) == VIR_STORAGE_TYPE_NETWORK
>>
>> Add a simple helper to simplify the pattern to
>> virStorageSourceIsLocalStorage(src)
> 
> Are you planning to use it anywhere out of those "lot of places"? :)

I stole this patch from my snapshot source handling refactor :

"[libvirt] [PATCHv4 00/29] (for 1.2.7) qemu: Refactor handling of disk
image metadata"

That series didn't get any reviews and I needed that functionality. It's
getting a lot of love in that series :)

> 
>> ---
>>  src/libvirt_private.syms  | 1 +
>>  src/util/virstoragefile.c | 7 +++++++
>>  src/util/virstoragefile.h | 1 +
>>  3 files changed, 9 insertions(+)
> 
> ACK
> 
> Jan
> 



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 901 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140704/4c5f1e56/attachment-0001.sig>