[libvirt] [PATCH 2/2] wireshark: Honor API change coming with 1.12 release

Ján Tomko jtomko at redhat.com
Fri Jul 4 10:25:20 UTC 2014

On 07/04/2014 10:52 AM, Michal Privoznik wrote:
> At wireshark, they have this promise to change public dissector APIs
> only with minor version number change. Which they did when releasing
> the version of 1.12.
> Firstly, they've changed tvb_memdup() in
> a0c53ffaa1bb46d8c9db2ec739401aa411c9790e so now it takes four arguments
> instead of three. The new argument is placed at the very beginning of
> the list of arguments and basically says the scope where we'd like to
> allocate the memory. According to the documentation NULL should be the
> default value.
> Then, the tcp_dissect_pdus() signature changed too. Well, the function
> that actually dissects reassembled packets as tcp_dissect_pdus()
> reorder TCP packets into one big chunk and then calls a user function
> to dissect the PDU at once. The change is dated back to
> 8081cf1d90397cbbb4404f9720595e1537ed5e14.
> Then, WS_DLL_PUBLIC_NOEXTERN was replaced with WS_DLL_PUBLIC_DEF in
> 5d87a8c46171f572568db5a47c093423482e342f.
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  tools/wireshark/src/packet-libvirt.c    | 32 +++++++++++++++++++++++++++++++-
>  tools/wireshark/util/make-dissector-reg |  7 +++++++
>  2 files changed, 38 insertions(+), 1 deletion(-)

You can include this bug link in the commit message:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140704/7ac5909e/attachment-0001.sig>

More information about the libvir-list mailing list