[libvirt] [PATCH] properly set video ram size for qemu VGA video device

[Martin Kletzander]

On Mon, Jul 07, 2014 at 01:44:06PM +0200, Pavel Hrdina wrote:
>https://bugzilla.redhat.com/show_bug.cgi?id=1076098
>
>We support vram option for video devices in domain xml, but so far
>only for QXL it had some effect. VGA video device in QEMU can also
>accept the size of video ram and we should pass it.
>
>Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
>---
> src/qemu/qemu_command.c | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>index fb64cda..09e29c9 100644
>--- a/src/qemu/qemu_command.c
>+++ b/src/qemu/qemu_command.c
>@@ -4800,6 +4800,9 @@ qemuBuildDeviceVideoStr(virDomainDefPtr def,
>
>         /* QEMU accepts bytes for vram_size. */
>         virBufferAsprintf(&buf, ",vram_size=%u", video->vram * 1024);
>+    } else if (video->type == VIR_DOMAIN_VIDEO_TYPE_VGA) {

The patch [1] that adds this option also adds it for VMWare VGA, can
we use that too?

>+        /* QEMU accepts megabytes for vgamem_mb. */
>+        virBufferAsprintf(&buf, ",vgamem_mb=%u", video->vram / 1024);

How will this behave with pre-1.1.0 qemu (without the commit mentioned
[1])?  Will it (a) just skip the parameter or will it (b) error out?
In case of (b) this is a regression.

Martin

P.S.: Some tests in qemuxml2argv would go nicely with such change.

[1] 4a1e244eb65c646bdd938d9d137ace42d76c95a7
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140707/2b07a87a/attachment-0001.sig>