[libvirt] [PATCH] qemu: fix domxml-to-native failing when spice_tls is not enabled

Ján Tomko jtomko at redhat.com
Wed Jul 9 09:08:45 UTC 2014

On 06/27/2014 04:37 PM, Jincheng Miao wrote:
> The default graphics channel mode is 'any', so as to defaultMode attribute.
> If defaultMode and channel mode are all the default value 'any',
> qemuConnectDomainXMLToNative will set TLSPort.
> But in qemuBuildGraphicsSPICECommandLine, if spice_tls is not enabled, libvirtd
> will report an error to tell the user that spice TLS is disabled in qemu.conf.
> So qemuConnectDomainXMLToNative should check spice_tls is enabled,
> then decide to allocate an tlsPort number to this graphics.
> If user specified defaultMode is 'secure', qemuConnectDomainXMLToNative
> could allocate tlsPort, and then let qemuBuildGraphicsSPICECommandLine reports
> the spice_tls disabled error.
> The related bug is:
> https://bugzilla.redhat.com/show_bug.cgi?id=1113868
> Signed-off-by: Jincheng Miao <jmiao at redhat.com>
> ---
>  src/qemu/qemu_driver.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)

ACK, I will push this later.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140709/dcde588d/attachment-0001.sig>

More information about the libvir-list mailing list