[libvirt] [PATCH] util: storage: Fix build after 25924dec0f9329d429aadae14e273602307e2214

[Peter Krempa]

On 07/09/14 15:01, Eric Blake wrote:
> On 07/09/2014 02:05 AM, Peter Krempa wrote:
>> The commit referenced above changed function arguments of
>> virStorageFileGetMetadataFromBuf() but didn't tweak the
>> ATTRIBUTE_NONNULL tied to them. This was caught by coverity as it
>> actually obeys them. We disabled them for GCC and thus it didn't show
>> up.
> 
> Yeah, because gcc 4.8 still misbehaves on the attribute (silently
> "optimizing" code without flagging invalid uses).  There's been talk on
> the gcc list about fixing it, although probably no sooner than 4.10
> timeframe.
> 
>>
>> Additionally in commit 3ea661deeabadc3c114dfb6f662b9fd17d714a01 I passed
>> NULL to the backingFormat argument which was also marked as nonnull. Use
>> a dummy int's address when the argument isn't supplied so that the code
>> doesn't need to change much.
>> ---
>>  src/util/virstoragefile.c | 4 ++++
>>  src/util/virstoragefile.h | 3 +--
>>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> ACK.
> 

Pushed; Thanks.

Peter

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140709/ebb6a450/attachment-0001.sig>