[libvirt] [PATCH v2 3/4] conf: Always format seclabel's model

Ján Tomko jtomko at redhat.com
Thu Jul 10 16:09:18 UTC 2014

On 07/10/2014 04:04 PM, Michal Privoznik wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1113860
> We've always done that. Well, until 990e46c45. Point is, if we don't
> format model, we may lose a domain on libvirtd restart. If the
> seclabel is implicit however, we should skip it's formatting.

It seems we only generate a seclabel with model="none" with type="none".
Specifying other types (or the relabel attribute) with model="none" doesn't
make much sense.

Could we instead error out on other types than "none" when model is "none", or
(if we can't) silently correct it to type "none"?

Also, formatting model="none" in the status XML shouldn't be needed after that
since we only generate it with type="none" and we would reject other types.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140710/4e7818fd/attachment-0001.sig>

More information about the libvir-list mailing list