[libvirt] [PATCH 3/4] VIR_FREE: Avoid doing side work in callees

Eric Blake eblake at redhat.com
Tue Jul 15 20:05:33 UTC 2014

On 07/15/2014 06:38 AM, Michal Privoznik wrote:
> There are just two places where we rely on the fact that VIR_FREE()
> macro is without any side effects. In the future, this property of the
> macro is going to change, so we need the code to be adjusted to deal
> with argument passed to VIR_FREE() being evaluated multiple times.
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/conf/network_conf.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)

NACK; my v2 keeps the property, so we don't need to work around it
changing after all.


Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140715/a957d56a/attachment-0001.sig>

More information about the libvir-list mailing list