[libvirt] [PATCH] blockjob: wait for pivot to complete

[Eric Blake]

On 07/16/2014 07:19 AM, Peter Krempa wrote:
> On 07/14/14 18:18, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1119173 documents that
>> commit eaba79d was flawed in the implementation of the
>> VIR_DOMAIN_BLOCK_JOB_ABORT_ASYNC flag when it comes to completing
>> a blockcopy.  Basically, the qemu pivot action is async (the QMP
>> command returns immediately, but the user must wait for the
>> BLOCK_JOB_COMPLETE event to know that all I/O related to the job
>> has finally been flushed), but the libvirt command was documented
>> as synchronous by default.  As active block commit will also be
>> using this code, it is worth fixing now.
>>
>> * src/qemu/qemu_driver.c (qemuDomainBlockJobImpl): Don't skip wait
>> loop after pivot.
>>
>> Signed-off-by: Eric Blake <eblake at redhat.com>
>> ---
>>
>> Shown here with extra context, to hopefully aid the review.
>>
>>  src/qemu/qemu_driver.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
> 
> ACK,

Thanks; pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 604 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140716/02a9c8bd/attachment-0001.sig>