[libvirt] [PATCH v2 4/8] daemon: support passing FDs from the calling process

[Martin Kletzander]

On Thu, Jul 17, 2014 at 09:40:12AM +0100, Daniel P. Berrange wrote:
>On Wed, Jul 16, 2014 at 08:29:58PM +0200, Martin Kletzander wrote:
>> First FD is the RW unix socket to listen on, second one (if
>> applicable) is the RO unix socket.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  daemon/libvirtd.c | 45 +++++++++++++++++++++++++++------------------
>>  1 file changed, 27 insertions(+), 18 deletions(-)
>>
>> diff --git a/daemon/libvirtd.c b/daemon/libvirtd.c
>> index 4c926b3..d20aeae 100644
>> --- a/daemon/libvirtd.c
>> +++ b/daemon/libvirtd.c
>> @@ -56,6 +56,7 @@
>>  #include "virstring.h"
>>  #include "locking/lock_manager.h"
>>  #include "viraccessmanager.h"
>> +#include "virutil.h"
>>
>>  #ifdef WITH_DRIVER_MODULES
>>  # include "driver.h"
>> @@ -476,11 +477,19 @@ static int daemonSetupNetworking(virNetServerPtr srv,
>>      int unix_sock_ro_mask = 0;
>>      int unix_sock_rw_mask = 0;
>>
>> +    unsigned int cur_fd = STDIN_FILENO + 1;
>
>Shouldn't that be  STDERR not STDIN since the passed FDs start at 3
>not 1.
>

Oh, yes, I tried that with the value "3" and changed it right before
sending, my bad.

>> +    unsigned int nfds = virGetListenFDs();
>> +
>
>Regards,
>Daniel
>--
>|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
>|: http://libvirt.org              -o-             http://virt-manager.org :|
>|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
>|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140717/f7ceff9b/attachment-0001.sig>