[libvirt] [PATCH v1 4/7] virbitmap: Introduce virBitmapDoesIntersect

Daniel P. Berrange berrange at redhat.com
Tue Jul 22 08:53:07 UTC 2014


On Mon, Jul 21, 2014 at 10:09:56AM -0600, Eric Blake wrote:
> On 07/17/2014 10:12 AM, Michal Privoznik wrote:
> > This internal API just checks if two bitmaps intersect or not.
> > 
> > Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> > ---
> >  src/libvirt_private.syms |  1 +
> >  src/util/virbitmap.c     | 20 ++++++++++++++++++++
> >  src/util/virbitmap.h     |  3 +++
> >  tests/virbitmaptest.c    | 26 ++++++++++++++++++++++++++
> >  4 files changed, 50 insertions(+)
> > 
> > diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms
> > index 44403fd..256edd5 100644
> > --- a/src/libvirt_private.syms
> > +++ b/src/libvirt_private.syms
> > @@ -1016,6 +1016,7 @@ virBitmapClearBit;
> >  virBitmapCopy;
> >  virBitmapCountBits;
> >  virBitmapDataToString;
> > +virBitmapDoesIntersect;
> 
> The naming sounds awkward.  Maybe virBitmapIntersects or
> virBitmapHasIntersection would be better.

Perhaps even   virBitmapOverlaps is a bit easier to say ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list