[libvirt] [PATCH 1/2] qemu: add vhost-scsi-pci definitions

[Paolo Bonzini]

Il 24/07/2014 05:24, Nicholas A. Bellinger ha scritto:
> From: Mike Perez <thingee at gmail.com>
> 
> This patch adds the necessary definitions to support vhost-scsi-pci and
> VIR_DOMAIN_CONTROLLER_MODEL_SCSI_VHOST_SCSI in QEMU >= v1.5.x code.
> 
> This includes:
> 
>   - Add QEMU_CAPS_VHOST_SCSI
>   - Add virDomainControllerDef->wwpn pointer for the vhost-scsi wwpn.
>   - Setting the new model type in qemuSetSCSIControllerModel()
>   - Invoking virDomainPCIAddressReserveAddr() for vhost-scsi-pci in
>     qemuAssignDevicePCISlots()
>   - Add the 'wwpn=' device parameter in qemuBuildControllerDevStr()
>   - Add vhost-scsi-pci to >= v1.5.x qemucapabilitiesdata
>   - Add xml2argv and xml2xml tests for cmd_per_lun + max_sectors +
>     num_queues + wwpn.
> 
> Signed-off-by: Mike Perez <thingee at gmail.com>
> Signed-off-by: Nicholas Bellinger <nab at linux-iscsi.org>

Configuration still has to go through configfs; I'm not sure how using <disk>
and vhost-scsi together makes sense:

+    <disk type='block' device='disk'>
+      <source dev='/dev/HostVG/QEMUGuest1'/>
+      <target dev='sdb' bus='scsi'/>
+      <address type='drive' controller='0' bus='0' target='0' unit='0'/>
+    </disk>
+    <controller type='usb' index='0'/>
+    <controller type='scsi' index='0' model='vhost-scsi'>
+      <driver wwpn='naa.60014050a13df4f2'/>
+    </controller>

...

+-device vhost-scsi-pci,id=scsi0,wwpn=naa.60014050a13df4f2 \
+-usb \
+-drive file=/dev/HostVG/QEMUGuest1,if=none,id=drive-scsi0-0-0-0 \
+-device scsi-disk,bus=scsi0.0,channel=0,scsi-id=0,lun=0,\
+drive=drive-scsi0-0-0-0,id=scsi0-0-0-0 \

and I'm not sure even how it can work since vhost-scsi-pci doesn't expose
a QEMU SCSI bus.

Paolo