[libvirt] [PATCH v2 2/3] nodedev: move pci express types to virpci.h

[Martin Kletzander]

On Wed, Jul 23, 2014 at 09:06:07PM -0600, Eric Blake wrote:
>Finding virPCIE* code is more intuitive if located in virpci.h
>instead of node_device_conf.h.
>
>* src/conf/node_device_conf.h (virPCIELinkSpeed, virPCIELink)
>(virPCIEDeviceInfo): Move...
>* src/util/virpci.h: ...here.
>* src/conf/node_device_conf.c (virPCIELinkSpeed): Likewise.
>
>Signed-off-by: Eric Blake <eblake at redhat.com>
>---
> src/conf/node_device_conf.c |  3 ---
> src/conf/node_device_conf.h | 29 +----------------------------
> src/util/virpci.c           |  3 +++
> src/util/virpci.h           | 30 +++++++++++++++++++++++++++++-
> 4 files changed, 33 insertions(+), 32 deletions(-)
>
>diff --git a/src/util/virpci.h b/src/util/virpci.h
>index d64c3e2..edec439 100644
>--- a/src/util/virpci.h
>+++ b/src/util/virpci.h
[...]
>+typedef struct _virPCIEDeviceInfo virPCIEDeviceInfo;
>+typedef virPCIEDeviceInfo *virPCIEDeviceInfoPtr;
>+struct _virPCIEDeviceInfo {
>+    /* Not all PCI Express devices has link. For example this 'Root Complex

I know it's pre-existing, but reading "devices has link" makes the
back of my head itch, shouldn't it be 'have'?  Could you change it if
I am right?

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140724/883a37cc/attachment-0001.sig>