[libvirt] [PATCH v2 5/8] Add virConnectPtr for qemuBuildSCSIHostdevDrvStr

[John Ferlan]

On 07/23/2014 09:31 PM, Eric Blake wrote:
> On 07/21/2014 02:47 PM, John Ferlan wrote:
>> Add a conn for future patches to be able to grab the secret when
>> authenticating an iSCSI host device
>>
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>  src/qemu/qemu_command.c |  5 +++--
>>  src/qemu/qemu_command.h |  5 +++--
>>  src/qemu/qemu_driver.c  |  6 +++---
>>  src/qemu/qemu_hotplug.c | 34 ++++++++++++++++++++--------------
>>  src/qemu/qemu_hotplug.h |  9 ++++++---
>>  5 files changed, 35 insertions(+), 24 deletions(-)
>>
> 
>> +++ b/src/qemu/qemu_command.h
>> @@ -170,10 +170,11 @@ char * qemuBuildUSBHostdevDevStr(virDomainDefPtr def,
>>                                   virDomainHostdevDefPtr dev,
>>                                   virQEMUCapsPtr qemuCaps);
>>  
>> -char * qemuBuildSCSIHostdevDrvStr(virDomainHostdevDefPtr dev,
>> +char * qemuBuildSCSIHostdevDrvStr(virConnectPtr conn,
>> +                                  virDomainHostdevDefPtr dev,
>>                                    virQEMUCapsPtr qemuCaps,
>>                                    qemuBuildCommandLineCallbacksPtr callbacks)
>> -    ATTRIBUTE_NONNULL(3);
>> +    ATTRIBUTE_NONNULL(4);
>>  char * qemuBuildSCSIHostdevDevStr(virDomainDefPtr def,
> 
> While touching these two declarations, you could get rid of the space
> after * to be consistent to the style.
> 
> ACK
> 

The rest of the module used "char * " (19 definitions) - doing so
creates inconsistency in the module.  I'll send a follow-up patch to
reformat all calls and adjust spacing accordingly in the module (there's
a few others in src/qemu/*.h as well).

John