[libvirt] [PATCH] change blkiotune weight range min from 100 to 10

Martin Kletzander mkletzan at redhat.com
Thu Jul 24 13:44:07 UTC 2014

On Thu, Jul 24, 2014 at 03:31:53PM +0200, Ján Tomko wrote:
>On 07/24/2014 02:03 PM, Martin Kletzander wrote:
>> This reflects the same change made in kernel commit df457f845e (before
>> v2.6.38-rc7).  On the rare occasion when the user would try setting
>> the weight to value in range <10, 100) on older kernel, we will error
>> out with EINVAL properly.  Modifying the error message (adding a hint
>> for example) would cause weird logs, especially without stacked error
>> messages (I couldn't resist mentioning it again).
>> There is no (easy) way of getting the limits from kernel, since it's
>> not exposed.
>I think removing the limit checks from libvirt, as was done for ranges
>specified via XML, would be a nicer fix:

Oh, so we just failed to remove some of the checks in that series.
OK, I'll repost that as a v2.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140724/43f1bba4/attachment-0001.sig>

More information about the libvir-list mailing list