[libvirt] [PATCH 0/3] Multiple RNG device support

[Peter Krempa]

On 07/24/14 17:15, Ján Tomko wrote:
> On 07/24/2014 04:07 PM, Peter Krempa wrote:
>> Qemu and kernel support multiple RNG's, so I revived my old patch to add the support to libvirt.
>>
>> Peter Krempa (3):
>>   qemu: cgroup: Don't use NULL path on default backed RNGs
>>   virtio-rng: allow multiple RNG devices
>>   test: qemu: Add tests for multiple virtio-rng devices
>>
>>  src/conf/domain_audit.c                            |  4 +-
>>  src/conf/domain_conf.c                             | 58 +++++++++++-----------
>>  src/conf/domain_conf.h                             |  4 +-
>>  src/qemu/qemu_cgroup.c                             | 27 ++++++----
>>  src/qemu/qemu_command.c                            | 29 ++++++-----
>>  .../qemuxml2argv-virtio-rng-multiple.args          |  9 ++++
>>  .../qemuxml2argv-virtio-rng-multiple.xml           | 31 ++++++++++++
>>  tests/qemuxml2argvtest.c                           |  2 +
>>  8 files changed, 109 insertions(+), 55 deletions(-)
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-multiple.args
>>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-virtio-rng-multiple.xml
>>
> 
> ACK series, but moving the default setting of '/dev/random' to the XML parser
> would be nicer.

We could do that in qemu's device post parse callback so we don't
hardcode that for other drivers. That would also shed some of the code
that handles the possibility of using NULL there afterwards.


I'm contemplating on doing that in a separate patch though.

> 
> Jan
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140724/e32a08cc/attachment-0001.sig>