[libvirt] [PATCH] nodedev: fix a uninitialized variable build failure

Eric Blake eblake at redhat.com
Tue Jul 29 04:01:42 UTC 2014


On 07/28/2014 08:05 PM, Chen Hanxiao wrote:
> Fix a -Werror=maybe-uninitialized warring

s/warring/warning/

Uninitialized only if caps->type is out-of-bounds from its enum type.
ACK and pushed.

> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  src/conf/node_device_conf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/conf/node_device_conf.c b/src/conf/node_device_conf.c
> index 78bc63f..96524a6 100644
> --- a/src/conf/node_device_conf.c
> +++ b/src/conf/node_device_conf.c
> @@ -1349,7 +1349,7 @@ virNodeDevCapsDefParseXML(xmlXPathContextPtr ctxt,
>  {
>      virNodeDevCapsDefPtr caps;
>      char *tmp;
> -    int val, ret;
> +    int val, ret = -1;
>  
>      if (VIR_ALLOC(caps) < 0)
>          return NULL;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140728/c1916c9a/attachment-0001.sig>


More information about the libvir-list mailing list