[libvirt] [PATCH 2/2] network: Bring netdevs online later

Matthew Rosato mjrosato at linux.vnet.ibm.com
Tue Jul 29 15:34:56 UTC 2014

On 07/23/2014 10:08 AM, Eric Blake wrote:
> On 07/23/2014 07:49 AM, Martin Kletzander wrote:
>> On Tue, Jul 01, 2014 at 02:00:57PM -0400, Matthew Rosato wrote:
>>> Defer MAC registration until net devices are actually going
>>> to be used by the guest.  This patch does so by setting the
>>> devices online just before starting guest CPUs.
>> Does this have some upside/downside?  Are you trying to fix some
>> problem?  It would be nice to describe it in the commit message, so I
>> know what to focus on or why it's needed.  Depending on the answer
>> there might be a way how to unit-test it.
>>> +++ b/src/qemu/qemu_interface.c
>>> @@ -0,0 +1,65 @@
>>> +/*
>>> + * qemu_interface.c: QEMU interface management
>>> + *
>>> + * Copyright (C) 2014 Red Hat, Inc.
>>> + * Copyright IBM Corp. 2014
>>> + *
>> I don't understand this double copyright here, copy-paste mistake?
> If this file is copied from a pre-existing file with double copyright,
> and substantially borrows from that content rather than being fresh
> material, then keeping double copyright is ideal.  If this is something
> you mostly wrote yourself, and then just copied in boilerplate, then
> it's simpler to just put one copyright line for yourself (in this case,
> IBM); then later, if other contributors make contributions, a second
> line can be added then (I tend to add Red Hat copyright whenever I touch
> files, since I'm doing my work on Red Hat time).  I don't see it as a
> show-stopper either way, because these days, git log is more reliable
> for telling who contributed what portions of a file.

Copied for boilerplate, so I'll strike the Red Hat line for now --
Thanks for the detailed info!


More information about the libvir-list mailing list