[libvirt] [PATCH v2] tests: Avoid double linking some libraries

[Michal Privoznik]

On 03.07.2014 21:29, Eric Blake wrote:
> On 07/03/2014 01:17 PM, Michal Privoznik wrote:
>> The problem is, since 614581f32b domaincapstest is linked with
>> $(LDADDS) by default. Then, since 94e3f23e8a7 the test may be
>> conditionally linked with $(qemu_LDADDS) which already contains
>> $(LDADDS). And some linkers doesn't cope with this nicely:
>>
>>    CCLD     domaincapstest
>> ../src/libvirt_probes.o:(.probes+0x0): multiple definition of `libvirt_event_poll_add_handle_semaphore'
>> ../src/libvirt_probes.o:(.probes+0x0): first defined here
>> ../src/libvirt_probes.o:(.probes+0x2): multiple definition of `libvirt_event_poll_update_handle_semaphore'
>> ../src/libvirt_probes.o:(.probes+0x2): first defined here
>> ../src/libvirt_probes.o:(.probes+0x4): multiple definition of `libvirt_event_poll_remove_handle_semaphore'
>> ../src/libvirt_probes.o:(.probes+0x4): first defined here
>> ../src/libvirt_probes.o:(.probes+0x6): multiple definition of `libvirt_event_poll_dispatch_handle_semaphore'
>> ../src/libvirt_probes.o:(.probes+0x6): first defined here
>>
>> And so on.
>>
>> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> ---
>>
>> diff to v1:
>> -fix securityselinuxlabeltest too
>>
>>   tests/Makefile.am | 31 ++++++++++++++++---------------
>>   1 file changed, 16 insertions(+), 15 deletions(-)
>
> This version makes sense to me. Rather than hiding LDADDS inside
> qemu_LDADDS, it makes qemu_LDADDS be only the additional libraries to
> add, and thus usable in conditions.
>
> ACK.
>

Thanks, pushed now.

Michal